Removed the ruby 1.8 build from travis #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainbeeston
force-pushed
the
remove-ruby-18
branch
2 times, most recently
from
5bda0b6 to
f4233ca
Compare
Ruby 1.8 support hasn't worked for some time, and we've been ignoring build failures on travis for ruby 1.8. Here are some examples of code that has already been released, which is incompatible with ruby 1.8: * DateTime.rfc3339 was only introduced in ruby 1.9 * Hash#select was changed to return a Hash in ruby 1.9 * Hash keys became ordered in ruby 1.9 I haven't added anything to the changelog because this isn't a new thing, it's been the reality for some time.
iainbeeston
force-pushed
the
remove-ruby-18
branch
from
f4233ca to
3912ab6
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 1.8 support hasn't worked for some time, and we've been ignoring
build failures on travis for ruby 1.8. Here are some examples of code
that has already been released, which is incompatible with ruby 1.8:
I haven't added anything to the changelog because this isn't a new
thing, it's been the reality for some time.