Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to using API v3 #102

Merged
merged 1 commit into from
May 24, 2023
Merged

Default to using API v3 #102

merged 1 commit into from
May 24, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented May 24, 2023

This removes the hack to always use v3 for the official forge by detecting the hostname. That was not taking puppet.com into account, which is now the preferred domain.

This is also much better because there was no way to use a config file to use API v3 by default. This is because librarian-puppet only allows strings in the config and no normalization to false was possible.

This removes the hack to always use v3 for the official forge by
detecting the hostname. That was not taking puppet.com into account,
which is now the preferred domain.

This is also much better because there was no way to use a config file
to use API v3 by default. This is because librarian-puppet only allows
strings in the config and no normalization to false was possible.
@ekohl
Copy link
Member Author

ekohl commented May 24, 2023

Documenting some research we did and discussed on IRC:

Pulp 2 may not implement API v3, but that's EOL now and we keep --use-v1-api if it's really needed. That can also be specified in a config (librarian-puppet config use-v1-api true).

@ekohl ekohl merged commit a414f11 into voxpupuli:master May 24, 2023
@ekohl ekohl deleted the default-api-v3 branch May 24, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants