Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Modulefile support #106

Merged
merged 1 commit into from
May 24, 2023
Merged

Drop Modulefile support #106

merged 1 commit into from
May 24, 2023

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented May 24, 2023

Puppet >= 4 does not support Modulefile and Puppet < 4 is long EOL.

This leaves a lot of tests referencing Modulefile because they install ancient versions. They should be updated.

Puppet >= 4 does not support Modulefile and Puppet < 4 is long EOL.

This leaves a lot of tests referencing Modulefile because they install
ancient versions. They should be updated.
@ekohl
Copy link
Member Author

ekohl commented May 24, 2023

Puppet 6 fails on

expected "librarian-puppet install" to have finished in time (RSpec::Expectations::ExpectationNotMetError)

It also failed a few other times. Perhaps it needs a higher timeout.

For now just merge it?

Copy link
Member

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge it!

@ekohl ekohl merged commit 152a524 into voxpupuli:master May 24, 2023
@ekohl ekohl deleted the drop-modulefile branch May 24, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants