Actually run acceptance tests #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wasn't testing anything
This is the same, but shorter. In modern aruba it will also start to show command output which makes debugging a lot easier.
The master branch (default from librarian) was removed so cloning failed.
It times out, probably due to a lot of backtracking of forge install due to older versions.
This test times out, but it's unclear to me what it should verify. It should have a mismatch, but it doesn't have a clear one.
The old versions caused it to time out. This updates it to recent versions and also asserts the apt module is properly pinned to an older version.
This relies on the 3.2.x branch in puppetlabs-stdlib but that was removed. This now uses theforeman-dns which has a stable branch and relatively few dependencies.
ekohl
force-pushed
the
fix-tests
branch
2 times, most recently
from
9528227 to
add5567
Compare
This tests the same but with newer versions, which speeds up the test. Regardless, the timeout is still increased. The correct stdlib version is now explicitly verified.
run_simple was deprecated in aruba 0.14.8 and renamed to run_command_and_stop in 1.0.0.
bastelfreak
reviewed
Jun 10, 2022
| @@ -1,7 +1,5 @@ | |||
| # Librarian-puppet | |||
|
|
|||
| [](https://travis-ci.org/voxpupuli/librarian-puppet) | |||
There was a problem hiding this comment.
do you want to add links for the new github action status?
There was a problem hiding this comment.
Personally I'd rather not.
bastelfreak
approved these changes
Jun 10, 2022
|
Looks like cc70745 broke Ruby 2.4 support because acceptance tests didn't ran. |
|
should we officially drop Ruby 2.4 (and maybe 2.5) since both are EoL? |
|
It was first released in 3.0.1, which was tagged over a year ago and I haven't seen complaints. I'm leaning to dropping 2.4, but not 2.5. 2.5 still works and is included in Puppet 6. That said, I do have more breaking changes lined up (this was just a preparation PR) so dropping it later sounds like a good idea. So I'm merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the filtering prevented from any cucumber tests from running. This meant the whole acceptance test suite wasn't running. This adds a bunch of commits to get them to work again. It also takes the chance to update the code to a more modern standard (5710fd0) which helps debugging when things fail.