Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian 10 and Red Hat 8 to the supported OS list #21

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Feb 12, 2020

This also adds CentOS since it's equivalent to Red Hat.

I'm not sure about the regular procedure to add distro support. I don't see any acceptance tests and don't have the capacity to properly test this myself.

@trevor-vaughan
Copy link

It works, I'm already using it on EL8.

Might as well add OEL 8 to the mix as well.

@ekohl
Copy link
Member Author

ekohl commented Feb 12, 2020

Looks like the CI infra needs to be updated from Precise to Xenial

@raphink
Copy link
Member

raphink commented Feb 13, 2020

@ekohl I've switched the travis distro in #22, can you rebase?

This also adds CentOS since it's equivalent to Red Hat
@ekohl ekohl force-pushed the add-distro-support branch from 80d88f4 to 68d51c5 Compare February 13, 2020 11:05
@ekohl
Copy link
Member Author

ekohl commented Feb 13, 2020

Rebased

@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.067% when pulling 68d51c5 on ekohl:add-distro-support into b55cab5 on hercules-team:master.

@ekohl
Copy link
Member Author

ekohl commented Feb 26, 2020

This is now green. Anything holding a merge back?

@trevor-vaughan
Copy link

@raphink I would like this as well. Also, any time frame for a new release once this is in? It looks like there were some minor bugs that were fixed that it would be nice to have.

@raphink raphink merged commit 77ca5b5 into voxpupuli:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants