Bump minimum required stdlib version to 4.13.0 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexjfisher can you take a look as to why one of the tests is failing. I don't think it has anything to do with your PR, but just want to be safe |
|
Looks like the acceptance tests just installs the latest forge release of stdlib, so I don't think it can be related. All the same, I've kicked off the build again to see if it fails every time. |
|
@alexjfisher could you rebase this? PRs #51 and #52 should've fixed the issues tennis was having. |
This module uses the type `Stdlib::Absolutepath`, which was introduced in stdlib 4.13 https://github.com/puppetlabs/puppetlabs-stdlib/blob/5eebb740589a9f128b8d6a5cb7e40a347562f5fb/CHANGELOG.md#features-3 Fixes voxpupuli#46
alexjfisher
force-pushed
the
update_stdlib_dep
branch
from
db63f16 to
53b4c70
Compare
dhollinger
approved these changes
May 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module uses the type
Stdlib::Absolutepath, which was introduced in stdlib 4.13https://github.com/puppetlabs/puppetlabs-stdlib/blob/5eebb740589a9f128b8d6a5cb7e40a347562f5fb/CHANGELOG.md#features-3
Fixes #46