Update map and mount defined types to address #59 #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved all mapfile generation to the map defined type provided by @traylenator and instead have the mount defined type calling and passing values to the map defined type (if mapfile is not empty). This allows all current functionality to continue working, as well as, allowing the map defined type to be used standalone AND maintain the existing mapfile generation feature set. Tests and templates have been updated to account for the changes.
|
Once merged, we should be able to merge #58 as well |
bastelfreak
reviewed
Jun 13, 2017
| @@ -24,14 +24,27 @@ | |||
| # @param order Order in which entries will appear in the autofs map file. | |||
|
|
|||
| define autofs::map ( | |||
| String $mapcontent, | |||
| Array $mapcontent, | |||
There was a problem hiding this comment.
That has not been in a module release yet and was just merged earlier today before I identified some limitations that needed to be addressed.
Brings up a point - are breaking changes only tied to releases or to any merge?
bastelfreak
reviewed
Jun 13, 2017
manifests/map.pp
Outdated
| mode => $mapmode, | ||
| replace => $replace, | ||
| require => Package[ 'autofs' ], | ||
| notify => Service[ 'autofs' ], |
There was a problem hiding this comment.
a bit nitpicking: no whitespace around []
bastelfreak
reviewed
Jun 13, 2017
| target => $mapfile, | ||
| content => template($maptempl), | ||
| order => 1, | ||
| autofs::map { $title: |
bastelfreak
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all mapfile generation to the map defined type provided by
@traylenator and instead have the mount defined type calling and passing
values to the map defined type (if mapfile is not empty).
This allows all current functionality to continue working, as well as,
allowing the map defined type to be used standalone AND maintain the
existing mapfile generation feature set.
Tests and templates have been updated to account for the changes.
closes #59