adding paramter to define whether or not to manage the config file at… #411
Conversation
manifests/init.pp
Outdated
| @@ -132,6 +134,7 @@ | |||
| $cassandra_yaml_tmpl = 'cassandra/cassandra.yaml.erb', | |||
| $commitlog_directory = undef, | |||
| $commitlog_directory_mode = '0750', | |||
| $manage_config_file = true, | |||
There was a problem hiding this comment.
Can you add the Boolean datatype to this?
There was a problem hiding this comment.
So, in the format: Boolean $manage_config_file = true,?
There are other Boolean parameters for this class. Should I update all the boolean parameters to have their type defined? Should I update all the parameters to have their data type defined?
Just trying to understand if you have some balance of consistency you are trying to maintain, or just attempting this as a start a better style pattern.
There was a problem hiding this comment.
ah, sorry. I should be more clear. Puppet supports datatypes since a few releases. Migrating all existing parameter in all modules (we've 140 at the moment) takes quite some time. We would like to have datatypes at least for new parameters. It would be really awesome if you're interested in adding datatypes to other params as well, but that should happen in another pull request. The syntax you mentioned is correct. We've our review guidelines at the bottom of this page: https://voxpupuli.org/docs/#reviewing-a-module
zmarois
force-pushed
the
feature/optionally-manage-c
branch
from
d59517c to
cf45310
Compare
|
@zmarois can you take a look at the failing spec test? |
zmarois
force-pushed
the
feature/optionally-manage-c
branch
from
9990bb0 to
95746bc
Compare
|
Fixed it @bastelfreak. Is rebased and squashed well now. Sorry for the churn. |
|
Yep, these changes a clearer to read than #409. |
| @@ -132,6 +134,7 @@ | |||
| $cassandra_yaml_tmpl = 'cassandra/cassandra.yaml.erb', | |||
| $commitlog_directory = undef, | |||
| $commitlog_directory_mode = '0750', | |||
| Boolean $manage_config_file = true, | |||
| @@ -25,6 +25,8 @@ | |||
| # @param commitlog_directory_mode [string] The mode for the | |||
| # `commitlog_directory` is ignored unless `commitlog_directory` is | |||
| # specified. | |||
| # @param manage_config_file [boolean] Whether or not to manage the cassandra configuration | |||
|
Thanks @zmarois! |
I'm attempting to integrate this cassandra install with Priam. Priam manages the cassandra config, and the start/stop of the cassandra service, so I'd like to let it do that while still using this puppet module for initial install.
Replacement for PR-409 per @juniorsysadmin's reccommendation