Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processes plugin creates strange config #595

Closed
gytisgreitai opened this issue Dec 10, 2016 · 3 comments
Closed

Processes plugin creates strange config #595

gytisgreitai opened this issue Dec 10, 2016 · 3 comments
Labels
bug Something isn't working docs Improvements or additions to documentation

Comments

@gytisgreitai
Copy link
Contributor

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 3.8.7
  • Ruby: 1.9.3p484
  • Distribution: Ubuntu 14.04
  • Module version: 5.1

How to reproduce (e.g Puppet code you use)

Code taken from README.md:

  collectd::plugin::processes::process { 'collectd' : }
  collectd::plugin::processes::processmatch { 'elasticsearch' :
    regex => '.*java.*org.elasticsearch.bootstrap.Elasticsearch'
  }

What are you seeing

It generates the following once run on the server:

10-processes.conf:
<LoadPlugin processes>
  Globals false
</LoadPlugin>

What behaviour did you expect instead

I would expect it to contain definitions for elastic and collectd service.

If i use

class { 'collectd::plugin::processes':
   processes => ['process1', 'process2'],
   process_matches => [
     { name => 'process-all', regex => 'process.*' }
   ],
 }

everything works as expected

Output log

Info: Concat[/etc/collectd/conf.d/processes-config.conf]: Scheduling refresh of Service[collectd]
Info: Class[Collectd::Config]: Scheduling refresh of Class[Collectd::Service]
Info: Class[Collectd::Service]: Scheduling refresh of Service[collectd]

@juniorsysadmin
Copy link
Member

@juniorsysadmin juniorsysadmin added bug Something isn't working docs Improvements or additions to documentation needs-feedback Further information is requested labels Dec 20, 2016
@oscarkraemer
Copy link
Contributor

This seems to be the same issue as #652

oscarkraemer added a commit to oscarkraemer/puppet-collectd that referenced this issue Nov 8, 2017
This fixes a old silent bug that was created by
395036a

This commit makes it possible define single process again like:
collectd::plugin::processes::process { 'collectd' : }
Without also having to create:
class { 'collectd::plugin::processes':
  processes => [ 'foo', 'bar' }

This fixes the issues voxpupuli#652 and voxpupuli#595.
@juniorsysadmin juniorsysadmin removed the needs-feedback Further information is requested label Nov 9, 2017
@juniorsysadmin
Copy link
Member

Fixed by #712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants