fixed typos #234
Closed
fixed typos #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add .project to .gitignore, please ;) |
|
Oh, you want me to resubmit PR without it? |
|
It's fine in this PR. You can also squash these two commits together into one and force push to your branch, so it will show up as one combined commit also here. |
|
It looks like the test failures here are due to some general breakage in the rspec/rspec-puppet space that has occured in the last few days. As usual, I expect we will follow the solutions that the puppetlabs-* modules take. |
$collectd::params::root_user doesn't exist Most likely won't be anything other then 'root'
|
The rspec issues are due to a bug in puppet 2.7 that is not going to be fixed: rspec/rspec-core#1864 (comment). puppetlabs is pinning rspec-core to 3.1.7 until support for puppet 2.7 can be dropped. |
|
Can you rebase, the Travis issue was fixed. |
|
Rebase your changes to get the fixed tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$collectd::params::root_user variable doesn't exist
Most likely won't be anything other than 'root'