Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 6.0.0 #641

Closed
wants to merge 1 commit into from
Closed

release 6.0.0 #641

wants to merge 1 commit into from

Conversation

bastelfreak
Copy link
Member

This CHANGELOG.md was generated by the github changelog generator. Can someone please review it?

@bastelfreak bastelfreak force-pushed the rel600 branch 3 times, most recently from fbb59b5 to 53e7c76 Compare January 29, 2017 12:22
@alexjfisher
Copy link
Member

I'd prefer the historic changelog entries were preserved. https://github.com/skywinder/github-changelog-generator#migrating-from-a-manual-changelog

@vinzent vinzent added the needs-work not ready to merge just yet label Feb 10, 2017
@bastelfreak
Copy link
Member Author

Hi. Do we really want to keep the old, hand written entries if the generator can create them as well? This brings us a unified format with proper links to all the issues and PRs.

I agree with keeping the handcrafted entries if the generator fails, this happens sometimes for past releases (like the 0.0.1 in this case).

@bastelfreak
Copy link
Member Author

hold of merging until #604 is merged as well.

@alexjfisher
Copy link
Member

In this module, the old changelog has been very well maintained with 'bugs', 'breaking changes', 'enhancements' etc all carefully documented. IMO Replacing this with autogenerated noise would be a travesty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-work not ready to merge just yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants