Add support for Chain6 directive #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Sep 15, 2017
examples/plugins/iptables.pp
Outdated
| 'nat' => 'In_SSH', | ||
| 'filter' => 'HTTP', | ||
| }, | ||
| chains6 => { | ||
| 'nat' => 'In6_SSH', |
There was a problem hiding this comment.
A nat example for IPv6 is odd. I'd just leave this line out
| @@ -26,6 +26,20 @@ | |||
| end | |||
| end | |||
|
|
|||
| context ':ensure => present and :chains6 => { \'nat\' => \'In6_SSH\' }' do | |||
There was a problem hiding this comment.
Can you also use filter instead of nat? I know it doesn't matter that much, but it feels wrong :)
ekohl
approved these changes
Sep 15, 2017
|
@herver the example in the README could also be updated, ... two places for examples with this module. |
|
Sorry should have squashed commits first, to late now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #693 and adds support for the
Chain6configuration directive of theiptablesCollectd plugin.Closes GH-693