Flush plugin config files #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paramite
force-pushed
the
feature/flush-pkg-conf
branch
from
2545ee7 to
cd06de5
Compare
|
Hmm, seems like jobs 2288.1, 2288.2 and 2288.3 did not fail because of my patch, am I right? |
|
this is an issue in one of our dependencies and should be fixed with #834 |
|
@paramite can you please rebase against our latest master? |
|
Sure, gonna rebase |
paramite
force-pushed
the
feature/flush-pkg-conf
branch
3 times, most recently
from
35e7947 to
f2ab42b
Compare
Even though the conf.d directory is flushed before creating configuration, there are still some duplicate configuration files created by plugin package installation performed after the general flush. This patch makes sure those files are also removed (currently only for RedHat osfamily packaging). This patch also makes sure, that all irrelevant config files are flush after installation of each plugin package.
paramite
force-pushed
the
feature/flush-pkg-conf
branch
from
f2ab42b to
a864d0d
Compare
|
@bastelfreak Done |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Even though the conf.d directory is flushed before creating configuration,
there are still some duplicate configuration files created by plugin package
installation performed after the general flush. This patch makes sure those
files are also removed (currently only for RedHat osfamily packaging). This
patch also makes sure, that all irrelevant config files are flush after
installation of each plugin package.
This Pull Request (PR) fixes the following issues
n/a