Add pcie_errors plugin #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Feb 16, 2020
bastelfreak
reviewed
Feb 16, 2020
manifests/plugin/pcie_errors.pp
Outdated
| Optional[String] $source = 'sysfs', | ||
| Optional[String] $access_dir = undef, | ||
| Optional[Boolean] $report_masked = false, | ||
| Optional[Boolean] $persistent_notifications = false, |
There was a problem hiding this comment.
does Optional make sense here? In most cases undef isn't a useful value for a Boolean variable.
bastelfreak
reviewed
Feb 16, 2020
bastelfreak
added
enhancement
bastelfreak
reviewed
Feb 17, 2020
manifests/plugin/pcie_errors.pp
Outdated
| # | ||
| class collectd::plugin::pcie_errors ( | ||
| Enum['present', 'absent'] $ensure = 'present', | ||
| Optional[String] $source = 'sysfs', |
There was a problem hiding this comment.
We are never able to set $source to undef if it has a default value. We can only change sysfs to another string. Are sysfs and proc the only valid values? In that case we could use an enum here?
There was a problem hiding this comment.
Good point. Values other than sysfs and proc are treated as error. As suggested I changed data type to enum and updated test case.
|
It looks like build failed due to one of the configured repositories failing, which seems to be "random" issue not related to this change. @bastelfreak could failing job be repeated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pcie_errors plugin collects PCI Express errors from Device Status in Capability structure and from Advanced Error Reporting Extended Capability where available.