Fix type mismatch for ovs_stats port #959
Conversation
|
@mrunge can you take a look at the failing unit tests and maybe add an acceptance test for this change? We've a bunch of examples at https://github.com/voxpupuli/puppet-collectd/tree/master/spec/acceptance |
|
Thank you for your quick look. The failing tests lead me to the acceptance tests. If the tests are passing now, this should be good to go :) |
There are already tests, but they did not require quotation marks.
|
Okay, tests pass now and the tests also check for existence of quotation marks. |
|
can you please add an acceptance test for this as well? :) |
mrunge
force-pushed
the
ovs_stats
branch
2 times, most recently
from
3261fc5 to
d0a1caa
Compare
|
Tests fail with: |
ovs_stats does not exist anywhere on the test infra. Trying to load it is not going to fly. This reverts commit 4f1a798.
|
The package is not available on ubuntu and debian (which uses the same repo); it also fails to load on centos either. |
|
@bastelfreak any opinion to move forward here? |
Pull Request (PR) description
There is a typo in the template to create the ovs_stats config. For collectd, the given port number is a string, where
puppet-collectd treats this as a port, thus resulting as a number in the collectd config file.
Since collectd upstream uses 6640 by default, this option is rarely required.
This Pull Request (PR) fixes the following issues
Fixes: #958