Added option to delete the cron.deny file when $manage_users_deny is true. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschonec
force-pushed
the
delete_cron_dot_deny
branch
3 times, most recently
from
e5a54f3 to
08da145
Compare
bschonec
changed the title
|
LGTM. Won't approve since I don't use cron anymore :D |
|
Indeed. Unfortunately, I'm still stuck in the past.... |
|
@TheMeier , are the tests running properly? I see a bunch of "Could not retrieve fact ipaddress" errors. |
|
The actual test failures don't appear to be related to that. |
bschonec
force-pushed
the
delete_cron_dot_deny
branch
2 times, most recently
from
08da145 to
09c0311
Compare
|
Whoops, I put the management in cron.allow instead of cron.deny. Fixed with this updated branch. |
ghoneycutt
approved these changes
Dec 9, 2024
ghoneycutt
requested changes
Dec 9, 2024
bschonec
force-pushed
the
delete_cron_dot_deny
branch
from
4e9feed to
29ac9e2
Compare
|
@ghoneycutt acceptable test? I've very, very little experience writing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Ability to manage the existence of /etc/cron.deny. Some CIS audits recommend/require that if no entries are made to /etc/cron.deny then the file should be deleted.
This Pull Request (PR) fixes the following issues
Allows the deletion of /etc/cron.deny.
Reference #145