Fix style in README example #10
Conversation
| ensure => present, | ||
| set => 'file:///tmp/bar_set_content', | ||
| type => 'hash:net', | ||
| subscribe => File['/tmp/bar_set_content'], |
There was a problem hiding this comment.
This changes it from a require to subscribe. Is that intentional?
There was a problem hiding this comment.
Personally, I prefer -> over subscribe/require.
There was a problem hiding this comment.
Style guide (which we should either follow or submit PRs against) prefers the metaparameters. https://puppet.com/docs/puppet/latest/style_guide.html#chaining-arrow-syntax
There was a problem hiding this comment.
Just changing arrows to words, which is the preferred way to handle relationships.
There was a problem hiding this comment.
-> would translate to require. ~> would be subscribe.
There was a problem hiding this comment.
There was a problem hiding this comment.
I get it was a before/require, but it should be a subscribe/notify. If the networks change, then the ipset should change, too.
|
bump |
No description provided.