Implement check for max title length #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foxxx0
approved these changes
Oct 17, 2019
kBite
approved these changes
Oct 17, 2019
|
@bastelfreak Is there any specific reason why you made the max title length 26 chars? I ran into this limit today and was wondering what the reasoning behind this limit is :) |
|
I think there is a limit of 32 chars within ipsets. during an update, the script creates a temporary chain with the original name + somthing like |
|
https://github.com/voxpupuli/puppet-ipset/blob/master/files/ipset_sync#L225 I think that's the prefix we prepend to the original set name. |
|
Ah I see, that makes sense! Thanks for the quick response :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues