Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'sets' hash to configure 'ipset::set' resource via Hiera #42

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

kBite
Copy link

@kBite kBite commented Apr 22, 2021

Add ipset::sets parameter to enable configuration of ipset::set resources via Hiera.

Like 'puppet-ferm': (e.g.) ferm::rule resources via Hiera (https://github.com/voxpupuli/puppet-ferm).

@kBite kBite requested review from bastelfreak and foxxx0 April 22, 2021 16:02
Copy link
Member

@ghoneycutt ghoneycutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after rebase. Great work!

@kBite
Copy link
Author

kBite commented Apr 22, 2021

@ghoneycutt rebase done

@bastelfreak
Copy link
Member

I guess we need to merge #48 to fix the CI jobs

@bastelfreak bastelfreak added the enhancement New feature or request label Apr 23, 2021
@bastelfreak bastelfreak merged commit abefc67 into voxpupuli:master Apr 23, 2021
@kBite kBite deleted the ipset__sets branch April 23, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants