Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 'content' instead of 'source' to increase performance #60

Merged
merged 1 commit into from
Dec 29, 2021

Conversation

kBite
Copy link

@kBite kBite commented Dec 29, 2021

This pull-request replaces 'source' parameters with 'content' to increase performance of Puppet Servers / decrease load on Puppet Servers.

When serving (a lot of) agents concurrently using 'content' instead of 'source' mitigates 'attempt to read body out of block' errors.

Error: /Stage[main]/Ipset/File[/usr/local/bin/ipset_sync]: Could not evaluate: Could not retrieve file metadata for puppet:///modules/ipset/ipset_sync: Request to https://<puppetserver>:8140/puppet/v3/file_metadata/modules/ipset/ipset_sync?links=manage&checksum_type=sha256&source_permissions=ignore&environment=stable failed after 583.136 seconds: attempt to read body out of block

@kBite kBite requested a review from bastelfreak December 29, 2021 19:36
@bastelfreak bastelfreak added the enhancement New feature or request label Dec 29, 2021
@bastelfreak bastelfreak merged commit 91fdaa0 into voxpupuli:master Dec 29, 2021
@kBite kBite deleted the use-content-instead-of-source branch December 30, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants