Ensure plugin download exec is idempotent

[davidsnyder]

Since this is a blind exec, it's re-downloading the plugins every puppet run, which then triggers the jenkins service notify. This means that jenkins is needlessly restarted every time puppet agent runs, killing any currently running jobs. This skips the exec if the file already exists (only for .hpi)

[jenkinsadmin]

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

[rtyler]

That's weird, I could have sworn this was protected by a creates parameter on the exec.

[igalic]

have you considered using @maestrodev's wget module instead?

[jchristi]

The download is idempotent IF the installed version is the same as the specified version. We can not rely on the creates attribute because different versions will create the same file, which is why the jenkins_plugins fact was created. The idempotence of the same installed version is achieved with this line:

if (empty(grep([ $::jenkins_plugins ], $search))) {

This is verified in the rspec tests (spec/defines/jenkins_plugin_spec.rb).

[jchristi]

That is to say, merging this change would break the ability to upgrade plugins.

[rtyler]

I think the right solution here might be to get my rtyler/jpm work properly squared away

[jhoblitt]

I see that the cli has the ability to do plugin management, probably using the plugin manager exposed through the http interface (haven't checked the source). Does it not do something that's being done by puppet::plugin?

[jhoblitt]

@davidsnyder We do appreciate your efforts! This issue should be resolved by #336, so I'm going to close out this pR.