Fix #16 by specifying VENV_PATH when running letsencrypt. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheistermann
force-pushed
the
fix-venvpath
branch
from
29496d3 to
2a13761
Compare
|
Thanks @mheistermann! I'm going to take a look at this PR today! |
| @@ -8,6 +8,7 @@ | |||
| $package_ensure = 'installed' | |||
| $config_file = '/etc/letsencrypt/cli.ini' | |||
| $path = '/opt/letsencrypt' | |||
| $venv_path = '/opt/letsencrypt-venv' # virtualevn path for vcs-installed letsencrypt | |||
There was a problem hiding this comment.
What do you think about changing this to /opt/letsencrypt/.venv?
Issue copy-paste from voxpupuli#16 When you install letsencrypt using the VCS method, it will create a virtualenv, which would normally be located in ~/.local/share/letsencrypt: Excerpt from letsencrypt-auto: ``` XDG_DATA_HOME=${XDG_DATA_HOME:-~/.local/share} VENV_NAME="letsencrypt" VENV_PATH=${VENV_PATH:-"$XDG_DATA_HOME/$VENV_NAME"} ``` However, puppet exec's will not set $HOME, which will stop Debian's /bin/sh, dash, from expanding ~, so it creates a literal '~' folder.
mheistermann
force-pushed
the
fix-venvpath
branch
from
2a13761 to
49fe775
Compare
|
Sure! Changed it to the suggested path and updated the PR. |
danzilio
added a commit
that referenced
this pull request
Mar 11, 2016
Fix #16 by specifying VENV_PATH when running letsencrypt.
|
Thanks @mheistermann! I'll push a release to the forge today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue copy-paste from
#16
When you install letsencrypt using the VCS method, it will create a
virtualenv, which would normally be located in
~/.local/share/letsencrypt:
Excerpt from letsencrypt-auto:
However, puppet exec's will not set $HOME, which will stop Debian's
/bin/sh, dash, from expanding
, so it creates a literal '' folder.