Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora 31, drop Fedora 29 #216

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Add Fedora 31, drop Fedora 29 #216

merged 2 commits into from
Apr 2, 2020

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Dec 31, 2019

Fedora 29 is EOL since November 26th. Since there's no actual code change, it'll still continue to work for users. To make that happen, the Hiera hierachy is changed to allow setting variables per-OS.

Fedora will never have EPEL. This makes it easier to keep supporting
Fedora.
Fedora 29 is EOL since November 26th. Since there's no actual code
change, it'll still continue to work for users.
@dhoppe
Copy link
Member

dhoppe commented Jan 3, 2020

Puppet does not provide any packages for Fedora 31.

@ekohl
Copy link
Member Author

ekohl commented Jan 3, 2020

Should we drop the acceptance tests for it or not list it as supported at all?

@dhoppe
Copy link
Member

dhoppe commented Jan 3, 2020

Good question. Even if Puppet provides the required packages, facterdb might be the next problem.

@ekohl
Copy link
Member Author

ekohl commented Jan 3, 2020

On the other hand, nothing has really changed between F30 and F31 so how much value do the unit tests with facterdb actually provide?

@dhoppe
Copy link
Member

dhoppe commented Jan 3, 2020

I wonder how much sense it makes to test a rolling release. We do not do that with any other module.

@ekohl
Copy link
Member Author

ekohl commented Jan 3, 2020

Fedora is not a rolling release. It has a very clear 6 month release schedule. this isn't for Fedora Rawhide and it's not like Arch.

@dhoppe
Copy link
Member

dhoppe commented Jan 3, 2020

Good to know, but the Facts and Puppet packages will still not be available on time in the future.

@Rathios
Copy link
Contributor

Rathios commented Apr 2, 2020

Puppet packages for Fedora 31 have been available a while now. I'm one of those peeps using this module on Fedora 31 (using a locally modified version), so would love to see this merged.

@ekohl
Copy link
Member Author

ekohl commented Apr 2, 2020

Restarted the Fedora 31 builds

@ekohl
Copy link
Member Author

ekohl commented Apr 2, 2020

@dhoppe any last comments?

@ekohl ekohl merged commit a29bb84 into voxpupuli:master Apr 2, 2020
@ekohl ekohl deleted the fedora branch April 2, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants