add manifest to install dns-route53 plugin, along with tests #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The dns-route53 plugin was functional, but didn't manage the installation of the package. This creates a manifest to install it, along with tests.
I did not confirm the exact availability of every distribution - I assumed it would be available in the same versions that the dns-rfc2136 plugin is, so I copied that configuration. I have successfully tested these changes in our Centos7 environment.
This supports the only configuration option specific to that plugin,
--dns-route53-propagation-seconds: https://certbot-dns-route53.readthedocs.io/en/stable/