Add Cloudflare DNS plugin support #238
Conversation
CallumBanbery
force-pushed
the
feature/plugins/dns-cloudflare
branch
3 times, most recently
from
5db46ea to
0f17906
Compare
|
A bunch of the CI pipelines are failing with the same error, unrelated to my change. I'm unsure how to proceed since it's an underlying |
|
@CallumBanbery these failures are happening in #235, which is where we could use help fixing this. |
|
Dear @CallumBanbery, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
#235 was merged and CI is green again. Would mind rebasing? |
Adding feature support for the Certbot DNS Cloudflare plugin. The plugin itself allows for two types of authentication, API token or Global API Key and corresponding Email; as Cloudflare recommends the use of API tokens since they're more secure the plugin will prioritize token authentication if both a token and key are provided.
CallumBanbery
force-pushed
the
feature/plugins/dns-cloudflare
branch
from
0f17906 to
abe4750
Compare
|
I need maintainer approval to run the CI |
| @@ -1,3 +1,4 @@ | |||
| --- | |||
| letsencrypt::plugin::dns_rfc2136::package_name: 'python3-certbot-dns-rfc2136' | |||
| letsencrypt::plugin::dns_route53::package_name: 'python3-certbot-dns-route53' | |||
| letsencrypt::plugin::dns_cloudflare::package_name: 'python3-certbot-dns-cloudflare' | |||
There was a problem hiding this comment.
Could you add the same thing for Ubuntu 20.04?
There was a problem hiding this comment.
Hello @CallumBanbery, Just a quick question can this be used as is with Ubuntu 20.04, or is this not possible at the moment. Or is there a better way to implement dns certbot for cloudflare, mainly looking to do this with a wildcard.
Thank you in advance.
There was a problem hiding this comment.
I haven't personally tested Ubuntu 20.04, however apt search from my machine shows the same package name in use, so I don't foresee any reason why it wouldn't work.
|
I forked the source repository and did all the required tasks mentioned here, because i need this feature and want to use it soon. I opened a PR #279 this can be replaced by this if the author @CallumBanbery will not update soon its PR. |
|
@ekohl ore someone else who has the permission. This PR could be closed now. |
|
Thanks! |
Pull Request (PR) description
Adding feature support for the Certbot DNS Cloudflare plugin.
The plugin itself allows for two types of authentication, API token or Global API Key and corresponding Email so both are supported in this change.
Cloudflare recommends API tokens as they're more secure, so this module will prioritize token authentication over key authentication if both are provided.
This Pull Request (PR) fixes the following issues
n/a