init.pp: remove unused param $manage_dependencies #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure is fixed in #256. |
Usage of this class parameter was removed in commit ee77abc.
kenyon
force-pushed
the
remove-manage_dependencies
branch
from
d366010 to
dc1ebca
Compare
ekohl
approved these changes
Nov 15, 2021
I don't think it can cause breakage because the parameter was only used for the VCS install method which you removed in commit ee77abc. So users would have already had to update their usage of this module to handle that change, if they were using the VCS install method. With the note that haven't had a release yet that includes commit ee77abc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of this class parameter was removed in commit ee77abc.