Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create certificates from class parameter (hiera) #271

Merged
merged 2 commits into from
Jan 5, 2022
Merged

create certificates from class parameter (hiera) #271

merged 2 commits into from
Jan 5, 2022

Conversation

nod0n
Copy link
Contributor

@nod0n nod0n commented Jan 5, 2022

Pull Request (PR) description

Support passing a hash of certificates from Hiera to the letsencrypt class.
This PR just iterates over the hash and creates letsencrypt::certonly for each entry.

@nod0n nod0n requested a review from traylenator January 5, 2022 10:04
@traylenator traylenator added the enhancement New feature or request label Jan 5, 2022
@nod0n
Copy link
Contributor Author

nod0n commented Jan 5, 2022

rubocop is happy now. :)
should I squash the commits? Any other suggestions?

@traylenator traylenator merged commit e6a8da3 into voxpupuli:master Jan 5, 2022
@nod0n nod0n deleted the hiera branch January 11, 2022 08:10
@nod0n nod0n mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traylenator traylenator traylenator left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nod0n @traylenator