Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support logging cron output #277

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

treydock
Copy link
Contributor

Pull Request (PR) description

Allow logging letsencrypt renewal output. So far hoping this will be useful when post_commands don't fire, so debug what's going wrong there.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also consider adding / adjusting tests in spec/defines/letsencrypt_certonly_spec.rb near line 435 to ensure the new behavior does not break in the future.

manifests/certonly.pp Outdated Show resolved Hide resolved
manifests/certonly.pp Outdated Show resolved Hide resolved
@root-expert
Copy link
Member

Please squash your commits before merging. Thanks!

@treydock
Copy link
Contributor Author

Commits squashed

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@treydock treydock merged commit 4bb2cdd into voxpupuli:master Nov 18, 2022
@treydock treydock deleted the cron-logger branch November 18, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants