Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary exec #309

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Remove unnecessary exec #309

merged 1 commit into from
Feb 12, 2023

Conversation

deric
Copy link
Contributor

@deric deric commented Feb 12, 2023

Executing letsencrypt -h is not needed when installing binaries from a package.

ekohl
ekohl approved these changes Feb 12, 2023
View reviewed changes
manifests/init.pp
}

contain letsencrypt::renew

# TODO: do we need this command when installing from package?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad a TODO is solved :)

@ekohl ekohl merged commit 51878bb into voxpupuli:master Feb 12, 2023
@ekohl ekohl added the enhancement New feature or request label Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deric @ekohl