Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate the package_ensure parameter to all plugins #321

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Propagate the package_ensure parameter to all plugins #321

merged 1 commit into from
Jun 29, 2023

Conversation

martijndegouw
Copy link
Contributor

Pull Request (PR) description

Propagate the package_ensure parameter to all plugins

smortex
smortex reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but maybe we can make this even simpler? I am not a user of this module so may be wrong, see my in-line comments.

manifests/plugin/dns_route53.pp Outdated Show resolved Hide resolved
manifests/plugin/dns_route53.pp Outdated Show resolved Hide resolved
manifests/plugin/dns_cloudflare.pp Outdated Show resolved Hide resolved
@martijndegouw martijndegouw force-pushed the feature/propagepackageensuretonginxplugin branch from 01796f5 to da6bf38 Compare June 28, 2023 19:16
@martijndegouw martijndegouw force-pushed the feature/propagepackageensuretonginxplugin branch from da6bf38 to 2a9e467 Compare June 28, 2023 19:20
smortex
smortex approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am not a user of the module so maybe another review would be welcome.

@bastelfreak bastelfreak added the bug Something isn't working label Jun 29, 2023
@bastelfreak bastelfreak merged commit 2dcc8a7 into voxpupuli:master Jun 29, 2023
@kenyon kenyon mentioned this pull request Oct 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martijndegouw @smortex @bastelfreak