Add a certbot_version fact
#322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijndegouw
force-pushed
the
feature/certbotversion
branch
from
b9ca07d to
33e65ef
Compare
bastelfreak
reviewed
Jun 30, 2023
lib/facter/certbot_version.rb
Outdated
| # frozen_string_literal: true | ||
|
|
||
| Facter.add(:certbot_version) do | ||
| confine kernel: %w[FreeBSD Linux OpenBSD] |
There was a problem hiding this comment.
we should confine on Facter::Util::Resolution.which('certbot') and not on the kernel I think?
There was a problem hiding this comment.
To be honest I copied that over from letsencrypt_directory.rb, assuming it would limit the fact to the supported operation systems only.
ekohl
reviewed
Jun 30, 2023
lib/facter/certbot_version.rb
Outdated
| value = nil | ||
| certbot = Facter::Util::Resolution.which('certbot') | ||
| if certbot | ||
| output = Facter::Util::Resolution.exec("#{certbot} --version 2>/dev/null") |
There was a problem hiding this comment.
exec is deprecated and execute should now be used: https://github.com/puppetlabs/facter/blob/b0d04b9aae82c1b7f58c92326667b4e2488eaf35/lib/facter/custom_facts/core/execution.rb#L90-L101
There was a problem hiding this comment.
ah thanks, I always mix those two up.
martijndegouw
force-pushed
the
feature/certbotversion
branch
2 times, most recently
from
3cd3e05 to
169738a
Compare
bastelfreak
approved these changes
Jun 30, 2023
ekohl
approved these changes
Jun 30, 2023
smortex
reviewed
Jun 30, 2023
|
|
||
| setcode do | ||
| output = Facter::Core::Execution.execute('certbot --version 2>/dev/null') | ||
| output[%r{^certbot (.*)$}, 1] if output |
martijndegouw
force-pushed
the
feature/certbotversion
branch
from
169738a to
daa8363
Compare
kenyon
approved these changes
Jun 30, 2023
smortex
approved these changes
Jun 30, 2023
smortex
changed the title
certbot_version fact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request (PR) adds the certbot version as a fact.
This fact can be used to add support for new certbot features while maintaining compatibility with older version.
Note that it does not take a custom
$package_commandinto account.