add optional cron job for certificate renewal #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| command => $renewcommand, | ||
| user => root, | ||
| hour => $cron_hour, | ||
| minute => $cron_minute, |
There was a problem hiding this comment.
The syntax check is failing due to trailing whitespace on this line.
|
Hi @hdeadman! Thanks for the PR! I've left some comments inline. Also, can you please add a test for this feature? |
|
OK, thanks for the feedback. I made the updates you requested. |
danzilio
added a commit
that referenced
this pull request
Jan 3, 2016
add optional cron job for certificate renewal
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a cronjob that sets up a daily job to re-run letsencrypt-auto with same arguments plus the --keep-until-expiring argument so that certificate will be renewed when it is close to expiring. I tested this on a server with two websites on it and it scheduled two jobs which ran OK but didn't renew certificate because they aren't close to expiring. When I ran the command manually with the renew-by-default argument it did renew the certificate (but early).