-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matching resources other than classes in 0.2.x #6
Comments
OK after reviewing the commit it makes sense to me now. The intention was to check this: But we are also unintentionally checking the Metaparameter require like above. |
I'm also running into the same issue. I'm getting problems with resources like:
In this case it thinks Package['ipmitool'] should be Package['::ipmitool'] |
voxpupuli/puppet-lint-absolute_classname-check#6 Change-Id: I58f6ee3ce22a3826fadfb019d3c67be710ab95d7
Project: openstack/tripleo-heat-templates 61f31831bdafbbddc7b68606832723fe2516872a Pin puppet-lint-absolute_classname-check to 0.1.3 voxpupuli/puppet-lint-absolute_classname-check#6 Change-Id: Ib0f1ce09b589630c6d09c8588246dafae2f2d387
voxpupuli/puppet-lint-absolute_classname-check#6 Change-Id: Ib0f1ce09b589630c6d09c8588246dafae2f2d387
voxpupuli/puppet-lint-absolute_classname-check#6 Change-Id: Ie6b69aef23c2028ad8632038a9a8283f4c1b8d40
Running in same issue everywhere in OpenStack, this is a total disaster. with this resource: https://github.com/openstack/puppet-openstacklib/blob/master/manifests/db/mysql.pp#L57 We pinned the gem for now, until a solution is found (btw, we have ~30 Puppet modules to fix if there is a solution). |
voxpupuli/puppet-lint-absolute_classname-check#6 Change-Id: I58f6ee3ce22a3826fadfb019d3c67be710ab95d7 (cherry picked from commit 51e77c6)
voxpupuli/puppet-lint-absolute_classname-check#6 Change-Id: I58f6ee3ce22a3826fadfb019d3c67be710ab95d7 (cherry picked from commit 51e77c6)
voxpupuli/puppet-lint-absolute_classname-check#6 Change-Id: I1b32075ad657d7ed7ec8d020b3d56805e30f47a4
@liamjbennett Any ideas on how to more accurately restrict your original change to the directives rather than metaparameters? |
Hey this is me too |
The lint check previously checked all tokens and so erroneously detected the 'require' metaparameter on a resource as a function call. All matching tokens that are within a resource declaration are now excluded from the lint check to ensure it only finds tokens in the main manifest or class bodies. Fixes voxpupuli#6
I've opened #7 with a fix. |
After updating to 0.2.x we now get false positives on References.
For example this now fails complaining about the require statement:
I cannot reconcile what commit did this, but the only major change seems to be this:
47c47f0
The text was updated successfully, but these errors were encountered: