Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php::globals: support Ubuntu 20.04 that ships php 7.4 #599

Merged
merged 1 commit into from
Nov 16, 2020
Merged

php::globals: support Ubuntu 20.04 that ships php 7.4 #599

merged 1 commit into from
Nov 16, 2020

Conversation

simondeziel
Copy link
Contributor

@simondeziel simondeziel commented Aug 31, 2020 •
edited
Loading

Replaces: #580

@pcfens
Copy link
Contributor

pcfens commented Nov 13, 2020

I was able to confirm that this works - what needs to happen to go ahead and get this merged?

@kenyon
Copy link
Member

kenyon commented Nov 14, 2020

We need to also add Ubuntu 20.04 to metadata.json, and get tests running for Ubuntu 20.04.

@kenyon kenyon added the needs-work not ready to merge just yet label Nov 14, 2020
@kenyon kenyon mentioned this pull request Nov 14, 2020
Closed
@bastelfreak
Copy link
Member

hey @simondeziel, thanks for the PR. Can you take a look at the .sync.yml / .travis.yml and add Ubuntu 20.04 there as well? (just copy 'n paste the 18.04 block is probably fine). This will enable acceptance tests for this platform.

@bastelfreak bastelfreak added the enhancement New feature or request label Nov 15, 2020
bastelfreak
bastelfreak reviewed Nov 15, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
@kenyon
Copy link
Member

kenyon commented Nov 15, 2020

I removed the failing puppet5 beaker test since puppet5 is not supported on Ubuntu 20.04: https://tickets.puppetlabs.com/browse/CPR-737

@kenyon kenyon removed the needs-work not ready to merge just yet label Nov 15, 2020
@simondeziel
Copy link
Contributor Author

Thank you both @bastelfreak and @kenyon. It looks like the last failure is due to a glitch preventing the installation of puppetlabs-apt module in the 16.04 env. The same test worked in previous updates of this PR. Could you either force a test re-run or maybe merge it as is? Thanks again.

@bastelfreak
Copy link
Member

I restarted the failed job

@bastelfreak bastelfreak merged commit b850252 into voxpupuli:master Nov 16, 2020
@simondeziel simondeziel deleted the ubuntu-20.04 branch November 16, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalic igalic igalic approved these changes

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simondeziel @pcfens @kenyon @bastelfreak @igalic