Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8 Support #627

Merged
merged 1 commit into from
Aug 19, 2021
Merged

Add PHP 8 Support #627

merged 1 commit into from
Aug 19, 2021

Conversation

bratucornel
Copy link
Contributor

@bratucornel bratucornel commented Jul 28, 2021

Pull Request (PR) description

Add Support for PHP 8

This Pull Request (PR) fixes the following issues

Fixes #612

@root-expert root-expert added the enhancement New feature or request label Aug 11, 2021
@smortex
Copy link
Member

smortex commented Aug 18, 2021

Can you please rebase your changes on top of the main branch? The CI should be green 😉

Rebasing instructions
$ cd path/to/work/directory
$ git fetch origin       # Download the latest code
$ git rebase origin/main # Move the commits on top of the main branch (might be named master)
$ git push -f            # Send the changes (-f is required because we re-wrote history)

@bastelfreak
Copy link
Member

Hi @bratucornel , can you please do the rebase as @smortex mentioned it and don't create a merge commit? This results in a cleaner git history.

@bratucornel
Copy link
Contributor Author

Hi @bratucornel , can you please do the rebase as @smortex mentioned it and don't create a merge commit? This results in a cleaner git history.

Hi @bastelfreak,

I did the rebase now. Hope it's ok.

Thanks

@bastelfreak bastelfreak merged commit d354c5b into voxpupuli:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants