Add ZendPHP support

[jbh]

Description

This PR adds support for ZendPHP on its supported platforms.

This is accomplished by adding two parameters to php::globals:

• Optional[Enum['community', 'zend']] $flavor
• Optional[Hash] $zend_creds

Usage examples

class { '::php::globals':
  php_version => '8.1',
  flavor      => 'zend',
}->
class { '::php':
  fpm       => true,
  fpm_pools => {
    www => {
      listen => "127.0.0.1:9000",
    },
  }
}

class { '::php::globals':
  php_version => '5.6',
  flavor      => 'zend',
  zend_creds  => {
    'username' => '<USERNAME>',
    'password' => '<PASSWORD>',
  },
}->
class { '::php':
  fpm       => true,
  fpm_pools => {
    www => {
      listen => "127.0.0.1:9000",
    },
  }
}

[jbh]

I'd like to expand the tests to include tests for this PR, but I can't seem to get the tests to run.

I've followed the instructions in the README:

bundle install --path vendor/bundle
bundle exec rake

but I keep getting this error about an undefined constant:

NameError: uninitialized constant PuppetStrings

module PuppetStrings::Tasks

Seems to be an issue within the puppet-strings gem. Any tips?

[root-expert]

Hello @jbh and thanks for the PR. You can read this document on how to run the spec suite

[jbh]

Thanks. I've figured out how to get tests running. Just trying to find the time to write them now! Should have tests up by the end of the week.

[jbh]

Sorry it took so long. I've added a few tests for the zend flavor.

[jbh]

Just wanted to check in and see if there is any sort of ETA for peer review and acceptance? This has been sitting for awhile.

[kenyon]

Also the commits should be rebased on current master and squashed into one commit.

[jbh]

Thanks for the review @kenyon. I'll get these sorted ASAP.

[jbh]

I can't seem to get it to squash properly WITH a rebase... But your requested changes have been completed.

Now there are five of the exact same commit... Lol... Squashing is a lot harder than I remember.

[jbh]

Okay! I finally got it squashed into one commit.

[kenyon]

Changelog update shouldn't be part of this PR.

[jbh]

Not sure how they got in there, but I've gotten CHANGELOG and REFERENCE taken out.

[kenyon]

I think we should leave this out of metadata.json since it makes zend/zend_common a hard requirement even when ZendPHP is not being used. Instead you can explain that zend/zend_common is needed for ZendPHP.

[jbh]

Fair enough. In that case, I can just remove metadata.json from the commit, which makes it easy!

[root-expert]

Please add some lines on README explaining that in order to use ZendPHP they need zend/zend_common puppet module, else people will be confused why their catalog is not compiling 😄

[jbh]

Done, @root-expert 😄

[root-expert]

Thanks for the work!