Add class parameter fpm_log_dir_mode to customize the file permission of log directory
#675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion of log directory.
kenyon
requested changes
Dec 14, 2022
There was a problem hiding this comment.
Would be nice to also add a test to https://github.com/voxpupuli/puppet-php/blob/master/spec/classes/php_spec.rb
|
Also mentioned in #523. |
Q-Storm
force-pushed
the
Adding_param_fpm_log_dir_mode
branch
from
60105ed to
fadd1e4
Compare
This is my first rspec test. I hope the test is as expected. |
kenyon
changed the title
kenyon
changed the title
fpm_log_dir_mode to customize the file permission of log directory
kenyon
approved these changes
Dec 19, 2022
smortex
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
I created the PR to parametrize the file permission for the php-fpm log directory.
This Pull Request (PR) fixes the following issues