Always use python3 wsgi apache module on Debian #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
force-pushed
the
apache-custom-config
branch
4 times, most recently
from
cd29dc0 to
bbe1928
Compare
kenyon
changed the title
kenyon
force-pushed
the
apache-custom-config
branch
2 times, most recently
from
5d0e8ff to
d97cd57
Compare
kenyon
force-pushed
the
apache-custom-config
branch
from
d97cd57 to
7582c7d
Compare
kenyon
force-pushed
the
apache-custom-config
branch
3 times, most recently
from
163587f to
db4c6e8
Compare
bastelfreak
approved these changes
Jan 22, 2022
puppetboard only uses python3, so this commit configures apache::mod::wsgi to use the python3 version by default on Debian. Before this fix, the python2 wsgi apache module would be installed (unless you were on Debian 11, in which case puppetlabs-apache configures apache::mod::wsgi to use the python3 version for you). Also use apache::custom_config in puppetboard::apache::conf instead of a plain file resource. Eventually this module should not have to know any apache implementation details, it would use puppetlabs-apache module resources instead. This helps move in that direction. Also convert the apache conf and ldap templates to EPP.
kenyon
force-pushed
the
apache-custom-config
branch
from
db4c6e8 to
789d6f8
Compare
|
Added an |
smortex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppetboard only uses python3, so this commit configures
apache::mod::wsgito use the python3 version by default on Debian 10. Before this fix, following the README for usingpuppetboard::apache::conf, the python2 wsgi apache module would be installed. With this PR we provide a working puppetboard installation by default, with less user configuration needed.Also use
apache::custom_configinstead of a plain file resource. Eventually this module should not have to know any apache implementation details, it would use puppetlabs-apache module resources instead. This helps move in that direction.Also convert the apache conf and ldap templates to EPP.
Fixes voxpupuli/puppetboard/issues/527