Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin_enable - controles both rabbitmq_management plugin and install of rabbitmqadmin #775

Closed
hjensas opened this issue Feb 11, 2019 · 2 comments · Fixed by #777
Closed

Comments

@hjensas
Copy link
Contributor

hjensas commented Feb 11, 2019

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 5.5.6
  • Ruby: 2.0.0.648
  • Distribution: CentOS 7 / RDO Openstack
  • Module version: 8.2.3-rc0

How to reproduce (e.g Puppet code you use)

Set parameter admin_enable: false

What are you seeing

rabbitmqadmin script is not installed.
rabbitmq_management plug-in is not loaded/enabled.
rabbitmq.config has no configuration for the management api.

What behaviour did you expect instead

The installation of rabbitmqadmin and enabling rabbitmq_management plugin should be separate.
The rabbitmqadmins script/program is a client tool, it can be installed on any workstation and used to manage any remote rabbitmq server/cluster with the rabbitmq_management plug-in enabled.

It should be possible to set up the rabbitmq server with the management API enabled, without also downloading and installing the client to use it.
Bonus: It should also be possible to only install the rabbitmqadmin client without also installing rabbitmq server.

Output log

N/A

Any additional information you'd like to impart

@bastelfreak
Copy link
Member

Hi @hjensas, thanks for bringing this up. Are you able to provide a PR for this?

@hjensas
Copy link
Contributor Author

hjensas commented Feb 12, 2019

I'm working on something. Will do some testing and then provide a PR.

hjensas added a commit to hjensas/puppet-rabbitmq that referenced this issue Feb 12, 2019
Enabling the rabbitmq_managemnt interface and installing the
rabbitmqadmin client was both controlled by the admin_enable
parameter.

Adds option enable_management (default: false). When this is
set to true, and admin_enable is false the rabbitmq_management
plugin is enabled, but the rabbitmqadmin client is not
installed.

For backward compatiblity the rabbitmq_management plugin is
also enabled when admin_enable is set to true.

Related voxpupuli#775
hjensas added a commit to hjensas/puppet-rabbitmq that referenced this issue Feb 12, 2019
Adds optional support to configure rabbitmq plugins by
writing configuration file (/etc/rabbitmq/enabled_plugins).

New parameter $use_config_file_for_plugins (boolean, default:
false) Can be used to enable this feature. When enabled it
replaces the use of the rabbitmqplugins provider to enable
plugins.

Fixes voxpupuli#775
hjensas added a commit to hjensas/puppet-rabbitmq that referenced this issue Feb 13, 2019
Enabling the rabbitmq_managemnt interface and installing the
rabbitmqadmin client was both controlled by the admin_enable
parameter.

Adds option enable_management (default: false). When this is
set to true, and admin_enable is false the rabbitmq_management
plugin is enabled, but the rabbitmqadmin client is not
installed.

For backward compatiblity the rabbitmq_management plugin is
also enabled when admin_enable is set to true.

Related voxpupuli#775
hjensas added a commit to hjensas/puppet-rabbitmq that referenced this issue Feb 13, 2019
Adds optional support to configure rabbitmq plugins by
writing configuration file (/etc/rabbitmq/enabled_plugins).

New parameter $use_config_file_for_plugins (boolean, default:
false) Can be used to enable this feature. When enabled it
replaces the use of the rabbitmqplugins provider to enable
plugins.

Fixes voxpupuli#775
hjensas added a commit to hjensas/puppet-rabbitmq that referenced this issue Feb 13, 2019
Adds optional support to configure rabbitmq plugins by
writing configuration file (/etc/rabbitmq/enabled_plugins).

New parameter $use_config_file_for_plugins (boolean, default:
false) Can be used to enable this feature. When enabled it
replaces the use of the rabbitmqplugins provider to enable
plugins.

Fixes voxpupuli#775
hjensas added a commit to hjensas/puppet-rabbitmq that referenced this issue Feb 13, 2019
Adds optional support to configure rabbitmq plugins by
writing configuration file (/etc/rabbitmq/enabled_plugins).

New parameter $use_config_file_for_plugins (boolean, default:
false) Can be used to enable this feature. When enabled it
replaces the use of the rabbitmqplugins provider to enable
plugins.

Fixes voxpupuli#775
hjensas added a commit to hjensas/puppet-rabbitmq that referenced this issue Feb 13, 2019
Adds optional support to configure rabbitmq plugins by
writing configuration file (/etc/rabbitmq/enabled_plugins).

New parameter $use_config_file_for_plugins (boolean, default:
false) Can be used to enable this feature. When enabled it
replaces the use of the rabbitmqplugins provider to enable
plugins.

Fixes voxpupuli#775
EmilienM pushed a commit that referenced this issue Feb 14, 2019
* Support enabling rabbitmq_management without rabbitmqadmin

Enabling the rabbitmq_managemnt interface and installing the
rabbitmqadmin client was both controlled by the admin_enable
parameter.

Adds option enable_management (default: false). When this is
set to true, and admin_enable is false the rabbitmq_management
plugin is enabled, but the rabbitmqadmin client is not
installed.

For backward compatiblity the rabbitmq_management plugin is
also enabled when admin_enable is set to true.

Related #775

* Support configuring plugins using enabled_plugins file

Adds optional support to configure rabbitmq plugins by
writing configuration file (/etc/rabbitmq/enabled_plugins).

New parameter $use_config_file_for_plugins (boolean, default:
false) Can be used to enable this feature. When enabled it
replaces the use of the rabbitmqplugins provider to enable
plugins.

Fixes #775
cegeka-jenkins pushed a commit to cegeka/puppet-rabbitmq that referenced this issue Mar 26, 2021
…xpupuli#777)

* Support enabling rabbitmq_management without rabbitmqadmin

Enabling the rabbitmq_managemnt interface and installing the
rabbitmqadmin client was both controlled by the admin_enable
parameter.

Adds option enable_management (default: false). When this is
set to true, and admin_enable is false the rabbitmq_management
plugin is enabled, but the rabbitmqadmin client is not
installed.

For backward compatiblity the rabbitmq_management plugin is
also enabled when admin_enable is set to true.

Related voxpupuli#775

* Support configuring plugins using enabled_plugins file

Adds optional support to configure rabbitmq plugins by
writing configuration file (/etc/rabbitmq/enabled_plugins).

New parameter $use_config_file_for_plugins (boolean, default:
false) Can be used to enable this feature. When enabled it
replaces the use of the rabbitmqplugins provider to enable
plugins.

Fixes voxpupuli#775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants