Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fact rabbitmq_plugins_dirs can crash the puppet run #783

Closed
jistr opened this issue Mar 25, 2019 · 0 comments · Fixed by #784
Closed

Fact rabbitmq_plugins_dirs can crash the puppet run #783

jistr opened this issue Mar 25, 2019 · 0 comments · Fixed by #784
Labels
bug Something isn't working

Comments

@jistr
Copy link
Contributor

jistr commented Mar 25, 2019

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 5.5.6
  • Ruby: 2.5.3

  • puppet-rabbitmq/lib/facter/rabbitmq_plugins_dirs.rb

    Lines 4 to 5 in 5477e69

    rabbitmq_pluginsdirs_env = Facter::Core::Execution.execute("rabbitmqctl eval 'application:get_env(rabbit, plugins_dir).'")
    rabbitmq_plugins_dirs = %r{^\{ok\,\"(\/.+\/\w+)}.match(rabbitmq_pluginsdirs_env)[1]

How to reproduce (e.g Puppet code you use)

Use the module on a system which doesn't have rabbitmqctl present. E.g. when we only want to generate configs but not manage RabbitMQ on that host.

What are you seeing

"Error: Facter: error while resolving custom fact "rabbitmq_plugins_dirs": undefined method `[]' for nil:NilClass",

This happens because:

      rabbitmq_pluginsdirs_env = Facter::Core::Execution.execute("rabbitmqctl eval 'application:get_env(rabbit, plugins_dir).'")

returns nil, and then we try to access index on that nil with [1].

What behaviour did you expect instead

Ignore the absence of rabbitmqctl, return empty list for rabbitmq_plugins_dirs fact.
jistr added a commit to jistr/puppet-rabbitmq that referenced this issue Mar 25, 2019
@jistr
Don't crash on rabbitmq_plugins_dirs fact if rabbitmqctl is not present
12989f5 
Before trying to access the contents of a regexp match, see if the
match was successful. On machines without rabbitmqctl this match will
return nil.

Fixes: voxpupuli#783
@jistr jistr mentioned this issue Mar 25, 2019
Merged
jistr added a commit to jistr/puppet-rabbitmq that referenced this issue Mar 26, 2019
@jistr
Don't crash on rabbitmq_plugins_dirs fact if rabbitmqctl is not present
47dbb24 
Before trying to access the contents of a regexp match, see if the
match was successful. On machines without rabbitmqctl this match will
return `nil`, so we can't index it with `[1]`. When that's the case,
the whole rabbitmq_plugins_dirs fact value will now be `nil`, instead
of throwing an exception.

Fixes: voxpupuli#783
jistr added a commit to jistr/puppet-rabbitmq that referenced this issue Mar 26, 2019
@jistr
Don't crash on rabbitmq_plugins_dirs fact if rabbitmqctl is not present
dff496b 
Before trying to access the contents of a regexp match, see if the
match was successful. On machines without rabbitmqctl this match will
return `nil`, so we can't index it with `[1]`. When that's the case,
the whole rabbitmq_plugins_dirs fact value will now be `nil`, instead
of throwing an exception.

Fixes: voxpupuli#783
jistr added a commit to jistr/puppet-rabbitmq that referenced this issue Mar 27, 2019
@jistr
Don't crash on rabbitmq_plugins_dirs fact if rabbitmqctl is not present
348c3ba 
Before trying to access the contents of a regexp match, see if the
match was successful. On machines without rabbitmqctl this match will
return `nil`, so we can't index it with `[1]`. When that's the case,
the whole rabbitmq_plugins_dirs fact value will now be `nil`, instead
of throwing an exception.

Fixes: voxpupuli#783
jistr added a commit to jistr/puppet-rabbitmq that referenced this issue Mar 27, 2019
@jistr
Don't crash on rabbitmq_plugins_dirs fact if rabbitmqctl is not present
ce7d4ce 
Before trying to access the contents of a regexp match, see if the
match was successful. On machines without rabbitmqctl this match will
return `nil`, so we can't index it with `[1]`. When that's the case,
the whole rabbitmq_plugins_dirs fact value will now be `nil`, instead
of throwing an exception.

Fixes: voxpupuli#783
@wyardley wyardley added the bug Something isn't working label Mar 27, 2019
cegeka-jenkins pushed a commit to cegeka/puppet-rabbitmq that referenced this issue Mar 26, 2021
@jistr
Don't crash on rabbitmq_plugins_dirs fact if rabbitmqctl is not present
c70080e 
Before trying to access the contents of a regexp match, see if the
match was successful. On machines without rabbitmqctl this match will
return `nil`, so we can't index it with `[1]`. When that's the case,
the whole rabbitmq_plugins_dirs fact value will now be `nil`, instead
of throwing an exception.

Fixes: voxpupuli#783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't crash on rabbitmq_plugins_dirs fact if rabbitmqctl is not present jistr/puppet-rabbitmq
2 participants
@jistr @wyardley