Add definition validation and munge for ha-sync-batch-size #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the release of RabbitMQ 3.6 there is an option to set the ha-sync-batch-size. This option takes an integer >0. This commit adds a validation statement to check the supplied value is an integer and then converts the string input into an integer.
Add missing _ that was causing failures.
|
I'm not sure how what I changed has caused tests to fail. Would someone with more experience be able to help me figure out why? |
| if definition.key? 'ha-sync-batch-size' | ||
| ha_sync_batch_size_val = definition['ha-sync-batch-size'] | ||
| unless ha_sync_batch_size_val.to_i.tos == ha_sync_batch_size_val | ||
| raise ArgumentErro, "Invalid ha-sync-batch-size value '#{ha_sync_batch_size_val}'" |
|
@combatdud3 You have a typo in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of RabbitMQ 3.6 there is an option to set the ha-sync-batch-size.
This option takes an integer >0. This commit adds a validation statement to check
the supplied value is an integer and then converts the string input into an
integer.