Switch back to using rabbitmq-plugins from system path (#566) #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
changed the title
wyardley
force-pushed
the
issues_566
branch
2 times, most recently
from
c8c8052 to
84d7412
Compare
wyardley
added
bug
wyardley
force-pushed
the
issues_566
branch
2 times, most recently
from
6310fa6 to
04a22c1
Compare
|
Also some discussion in #134 |
This was referenced Sep 6, 2017
wyardley
force-pushed
the
issues_566
branch
from
99514ba to
dafd0a7
Compare
|
FWIW, RabbitMQ 3.3.5 on CentOS 7 has this in |
wyardley
force-pushed
the
issues_566
branch
3 times, most recently
from
a7c48f1 to
ff53235
Compare
wyardley
force-pushed
the
issues_566
branch
from
ff53235 to
3272f93
Compare
wyardley
commented
Sep 12, 2017
| # Prefer rabbitmq-plugins if it's in $PATH, but fall back to /usr/lib/rabbitmq/bin | ||
| if Puppet::Util.which('rabbitmq-plugins') | ||
| has_command(:rabbitmqplugins, 'rabbitmq-plugins') do | ||
| environment HOME: '/tmp' |
There was a problem hiding this comment.
I did try manipulating PATH directly, but didn't have any luck when doing actual tests with it.
slm0n87
pushed a commit
to slm0n87/puppet-rabbitmq
that referenced
this pull request
Mar 7, 2019
Switch back to using rabbitmq-plugins from system path (voxpupuli#566)
cegeka-jenkins
pushed a commit
to cegeka/puppet-rabbitmq
that referenced
this pull request
Mar 26, 2021
Switch back to using rabbitmq-plugins from system path (voxpupuli#566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #566, it seems as if the command in
/sbinshould be preferred, at least with modern RabbitMQ versions. Not sure if we need to get too smart about it, or how far back we need to support in terms of versions... presumably it would be possible to have it fall back to the second path, but not sure if that's overkill.