Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, name, and required Puppet version #589

Merged
merged 1 commit into from
Sep 2, 2017

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Sep 1, 2017

Update dependencies, name, and required Puppet version

metadata.json Outdated
@@ -1,12 +1,12 @@
{
"name": "puppetlabs-rabbitmq",
"name": "puppet-rabbitmq",
"version": "5.6.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update version to an 'rc' version? 6.0.0-rc??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, 6.0.0-rc0? I figured that might get set when we do modulesync, but I don't see any reason not to update it, and next release will have a lot of breaking changes, I think.

@wyardley
Copy link
Contributor Author

wyardley commented Sep 2, 2017

@alexjfisher updated and tests completed

@alexjfisher alexjfisher merged commit 4355437 into voxpupuli:master Sep 2, 2017
@wyardley wyardley added the enhancement New feature or request label Sep 5, 2017
@wyardley wyardley deleted the update_metadata branch September 6, 2017 04:22
slm0n87 pushed a commit to slm0n87/puppet-rabbitmq that referenced this pull request Mar 7, 2019
Update dependencies, name, and required Puppet version
cegeka-jenkins pushed a commit to cegeka/puppet-rabbitmq that referenced this pull request Mar 26, 2021
Update dependencies, name, and required Puppet version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants