Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'require' statements and mock types to fix spec tests #620

Merged
merged 1 commit into from
Sep 9, 2017

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Sep 8, 2017

This resolves the issues I was having with running the rspec tests locally.

@wyardley
Copy link
Contributor Author

wyardley commented Sep 8, 2017

https://stackoverflow.com/questions/7844336/rspec-mustbeconfiguredbeforeexamplegroupserror-on-plain-project describes the reasoning behind this.
removing require 'mocha' and require 'mocha/api seems to result in the tests still working, so I'm thinking not needed, but welcome feedback.

@bastelfreak bastelfreak merged commit a3fdcb2 into voxpupuli:master Sep 9, 2017
@wyardley wyardley deleted the update_spec_tests branch September 9, 2017 23:29
slm0n87 pushed a commit to slm0n87/puppet-rabbitmq that referenced this pull request Mar 7, 2019
Update 'require' statements and mock types to fix spec tests
cegeka-jenkins pushed a commit to cegeka/puppet-rabbitmq that referenced this pull request Mar 26, 2021
Update 'require' statements and mock types to fix spec tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants