Add official support for CentOS 8 #900

kajinamit · 2022-02-07T11:51:24Z

Pull Request (PR) description

This change adds official support for CentOS 8. The current logic is
almost compatible except for the package name of Python 2, which is
python2 in CentOS 8 while python in CentOS 7.

This Pull Request (PR) fixes the following issues

N/A

spec/spec_helper_acceptance.rb

wyardley · 2022-02-08T01:50:15Z

spec/acceptance/class_spec.rb

+  repos_ensure = case fact('os.family')
+                 when 'RedHat'
+                   true
+                 end


So the current behavior of the module IIRC is that repos_ensure defaults to false. Changing it for the acceptance test here means (I think) that this will now not test the module’s default behavior.

there were some discussions of changing that default again in the module itself, but I think that would be more involved, and that’s where previous attempts at this have kind of stalled in the absence of an active maintainer.

#845 has some good discussion and I think is a good starting point.

I think the module should provide sane and working defaults for the different operating systems and the tests should at least cover the defaults. If we test non-default values as well that's a nice addition.

I understand what you mentioned but even for CentOS7 currently this module can't provide complete configuration. This still relies on puppet-eralang to enable epel, now.

Also, AFAIK Ubuntu doesn't require the additional repo and can install rabbitmq from usual OS repos. If we enable repos then default repos will be replaced, which I don't think would be ideal setup.

Why not enable repos_ensure only for RedHat? Since as it seems only RedHat needs extra repos to work out of the box.
That's a common pattern IMO

This module has never set up the required repositories by default. The current implementation relies on epel repository enabled externally. This change still keeps the same policy and let the users to enable the repository setup by their own(any external modules or setting this parameter.)
I initially hesitated to enable this because it can break existing usage(For example we use this module to deploy rabbitmq as part of OpenStack but in that case we use the rabbitmq package provided by RDO, not packagecloud. Enabling packagecloud repo conflicts with it). However if all agrees we should enable this and make the all users to handle this change properly then I can enable it.

@kajinamit this module did, at one point, when Puppet still maintained it, setup the RabbitMQ repo by default. It also had an option to include the simple distribution of erlang that rabbitmq uses.

For better or worse, I am responsible for making that change back then (#493). At the time, it seemed like a sane deafult. I think with hindsight, going back to the old behavior (with repos_ensure being default again, as a breaking change) is probably where things should go, it's just a matter of getting there when this project doesn't have an active maintainer.

manifests/repo/rhel/erlang.pp

manifests/init.pp

kajinamit · 2022-03-10T13:37:13Z

Hmm. Package installation is failing because of missing key. This is likely because two gpg keys are required[1]

[1] https://www.rabbitmq.com/install-rpm.html#package-cloud

vox-pupuli-tasks · 2022-06-21T19:54:56Z

Dear @kajinamit, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

kajinamit · 2023-03-08T01:59:25Z

It seems archi linux job is broken. I see it's failing with the same errors in #924 and I'm not sure how I can fix the job, honestly.

wyardley · 2023-03-08T02:40:05Z

It seems archi linux job is broken.

Hi - yes, don't worry about that. It's an issue bootstrapping rabbitmqadmin, and has been there for a while now.

kajinamit · 2023-03-08T03:21:37Z

thanks @wyardley .

I've rebased this on the latest master. it seems merge conflict tag is not purged automatically.

I'm wondering what I can do to get this PR merged. This has been floating for a while but I'm really eager to get this(and the subsequent work to support CentOS9) because we are extensively using this for OpenStack deployment.

As I mentioned in the early reply I'm not too sure whether I should enable the repository management which likely cause problems during upgrade. If people think that is the only blocker then I can fix that.

wyardley · 2023-03-08T03:36:19Z

@kajinamit maybe worth reading this comment in another PR that I made the other day too
#816 (comment)

High level, while I don't want to bikeshed this to death, this project doesn't have a real active maintainer right now, and so it has been hard to find someone who's able to get some of the things mentioned there working in a safe and testable way.

I do really disagree that we should be installing / managing erlang in this project, at least by default, so at a minimum, we cannot force that behavior without making it configurable and, ideally, set to false by default. That's because people may already have differing needs for which erlang version they need to manage, and / or may already be installing it, and it's important that this module first not break stuff. I'd be Ok with some more junk code to set it up in the integration test, and continue to document that the user needs to manage setting up erlang themself.

I think getting the integration tests running locally would be a good start, if you don't have those working yet; I have had struggles getting that to work recently, but it's honestly going to be very hard to do much on that if you don't have the test suite working (and exec-able into) locally.

You may be able to find some folks from vox who are able to help (esp. w/r/t getting integration tests working properly, as well as some ideas about the best way to handle the erlang dep) on their IRC channel. You could also see if there's any willingness to bump the metadata without appropriate and full working integration tests, but that's not a call I'd make on my own.

wyardley · 2023-03-08T04:10:56Z

If https://github.com/voxpupuli/puppet-erlang still is semi-maintained, and works(ish), one option would be to use that in the integration tests if it's not already used there, and just have it be a docs fix or optional dependency for users to use it.

kajinamit · 2023-03-08T06:19:48Z

@wyardley Thanks for these thoughts. these are quite valudable. Do you mind explaining what's the expected coverage of integration tests you mentioned ? I'm asking this because we already have acceptance tests, and I'd like to understand correctly what would be the missing coverage we should fill by integration tests.

While it's difficult to prepare the all supported operating system and versions and test all of these manually, I can prepare c9s box to test this. Also we actually use this module in our own CI so I'll explore the possibility to use that to test this PR.

wyardley · 2023-03-08T06:27:58Z

Sorry, I’m using the two terms interchangeably. Acceptance tests.

kajinamit · 2023-03-08T06:35:43Z

If https://github.com/voxpupuli/puppet-erlang still is semi-maintained, and works(ish), one option would be to use that in the integration tests if it's not already used there, and just have it be a docs fix or optional dependency for users to use it.

This is a really good idea, because the module support installing earlang from packagecloud. Let me explore this option.

kajinamit · 2023-03-08T06:54:06Z

ok it seems we have to get the new release of puppet-erlang which contains voxpupuli/puppet-erlang#15 .

wyardley · 2023-03-08T16:39:17Z

ok it seems we have to get the new release of puppet-erlang which contains voxpupuli/puppet-erlang#15 .

Sounds good. Key thing is, let's just document it vs. making it a module dependency (since it's not needed for people who bootstrap erlang on their own), or make including it optional vs. some kind of bool, but use it for setting up erlang in the acceptance test if needed.

Other thought: to keep stuff small, maybe we should release the repos_ensure: true breaking change as its own change first (to keep the PRs smaller), and then work on centos 8 / debian 10 etc. support after that?

bastelfreak · 2023-03-08T18:45:32Z

The release PR: voxpupuli/puppet-erlang#19

This change makes CentOS 8 and RHEL 8 as a suppotrted OS. For CentOS 8 RabbitMQ package is not available in EPEL and PackageCloud repos should be used instead. This change adds support for additional erlang repository so that users can install rabbitmq correctly without missing dependencies. Also, now acceptance tests use puppet-erlang instead of garethr-erlang so that it can install erlng from packagecloud. [1] https://www.rabbitmq.com/install-rpm.html

Currently the 'rabbitmq-plguins enable' command does not explicitly enable the plugin if that is implicitly enabled in CentOS. This change let the rabbitmq_federation plugin loaded before its management plugin to workaround the problem.

kajinamit · 2023-03-09T10:38:27Z

Thanks. I just got the job passing. I'll try to find time to attempt to enable repose_ensure by default later this week.

wyardley · 2024-05-19T17:53:23Z

Seems like CentOS 8 actually was EOL before this PR was even created?
@bastelfreak do you think we should provide support for it in one release, or just close?

Note: CentOS 8 has been EOL for a while, and RHEL 8 is EOL at the end of May, 2024. Thus, official support may be dropped again soon Fixes voxpupuli#942 Closes voxpupuli#900 Fixes voxpupuli#816

kajinamit force-pushed the centos-8 branch 6 times, most recently from 1b21ba7 to d865ca9 Compare February 7, 2022 16:20

bastelfreak reviewed Feb 7, 2022

View reviewed changes

spec/spec_helper_acceptance.rb Outdated Show resolved Hide resolved

kajinamit force-pushed the centos-8 branch 2 times, most recently from 52aeea1 to f965a40 Compare February 8, 2022 00:48

wyardley reviewed Feb 8, 2022

View reviewed changes

kajinamit force-pushed the centos-8 branch from f965a40 to dd2f963 Compare February 9, 2022 12:45

kajinamit force-pushed the centos-8 branch from dd2f963 to 963958b Compare March 10, 2022 12:52

bastelfreak reviewed Mar 10, 2022

View reviewed changes

manifests/repo/rhel/erlang.pp Outdated Show resolved Hide resolved

bastelfreak reviewed Mar 10, 2022

View reviewed changes

manifests/repo/rhel/erlang.pp Outdated Show resolved Hide resolved

bastelfreak reviewed Mar 10, 2022

View reviewed changes

manifests/init.pp Outdated Show resolved Hide resolved

bastelfreak added the enhancement New feature or request label Mar 10, 2022

kajinamit force-pushed the centos-8 branch 2 times, most recently from c8fd0de to 926314f Compare March 10, 2022 13:36

kajinamit force-pushed the centos-8 branch 5 times, most recently from 9f132dc to 4b036df Compare March 13, 2022 12:23

vox-pupuli-tasks bot added the merge-conflicts label Jun 21, 2022

kajinamit force-pushed the centos-8 branch 2 times, most recently from 9d8c548 to 8cbbe10 Compare July 3, 2022 16:10

kajinamit closed this Aug 16, 2022

kajinamit reopened this Aug 16, 2022

kajinamit reopened this Sep 6, 2022

kajinamit force-pushed the centos-8 branch from ce66e1f to abdc526 Compare January 18, 2023 06:46

kajinamit force-pushed the centos-8 branch from abdc526 to 3d9f79c Compare March 8, 2023 03:18

wyardley removed the merge-conflicts label Mar 8, 2023

kajinamit force-pushed the centos-8 branch from 3d9f79c to 85303c8 Compare March 8, 2023 06:34

kajinamit force-pushed the centos-8 branch from 85303c8 to f4a3562 Compare March 8, 2023 06:37

kajinamit force-pushed the centos-8 branch from f4a3562 to 13c7f57 Compare March 9, 2023 06:06

kajinamit force-pushed the centos-8 branch from 13c7f57 to e8456a7 Compare March 9, 2023 06:27

Load rabbitmq_federation plugin first

b08bd90

Currently the 'rabbitmq-plguins enable' command does not explicitly enable the plugin if that is implicitly enabled in CentOS. This change let the rabbitmq_federation plugin loaded before its management plugin to workaround the problem.

kajinamit force-pushed the centos-8 branch from e8456a7 to b08bd90 Compare March 9, 2023 07:05

kajinamit mentioned this pull request Mar 18, 2023

BREAKING: Enable packagecloud repos by default #926

Open

wyardley mentioned this pull request May 19, 2024

CentOS7: default to EPEL7 as source #983

Merged

wyardley closed this May 19, 2024

wyardley mentioned this pull request May 20, 2024

Support RHEL and CentOS 8 #992

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add official support for CentOS 8 #900

Add official support for CentOS 8 #900

kajinamit commented Feb 7, 2022

wyardley Feb 8, 2022

wyardley Feb 8, 2022

bastelfreak Feb 8, 2022

kajinamit Feb 9, 2022

kajinamit Feb 9, 2022

root-expert Mar 28, 2022

kajinamit Jul 3, 2022 •

edited

Loading

wyardley Mar 8, 2023

kajinamit commented Mar 10, 2022

vox-pupuli-tasks bot commented Jun 21, 2022

kajinamit commented Mar 8, 2023

wyardley commented Mar 8, 2023 •

edited

Loading

kajinamit commented Mar 8, 2023 •

edited

Loading

wyardley commented Mar 8, 2023

wyardley commented Mar 8, 2023

kajinamit commented Mar 8, 2023

wyardley commented Mar 8, 2023

kajinamit commented Mar 8, 2023

kajinamit commented Mar 8, 2023

wyardley commented Mar 8, 2023

bastelfreak commented Mar 8, 2023

kajinamit commented Mar 9, 2023

wyardley commented May 19, 2024

Add official support for CentOS 8 #900

Add official support for CentOS 8 #900

Conversation

kajinamit commented Feb 7, 2022

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

wyardley Feb 8, 2022

Choose a reason for hiding this comment

wyardley Feb 8, 2022

Choose a reason for hiding this comment

bastelfreak Feb 8, 2022

Choose a reason for hiding this comment

kajinamit Feb 9, 2022

Choose a reason for hiding this comment

kajinamit Feb 9, 2022

Choose a reason for hiding this comment

root-expert Mar 28, 2022

Choose a reason for hiding this comment

kajinamit Jul 3, 2022 • edited Loading

Choose a reason for hiding this comment

wyardley Mar 8, 2023

Choose a reason for hiding this comment

kajinamit commented Mar 10, 2022

vox-pupuli-tasks bot commented Jun 21, 2022

kajinamit commented Mar 8, 2023

wyardley commented Mar 8, 2023 • edited Loading

kajinamit commented Mar 8, 2023 • edited Loading

wyardley commented Mar 8, 2023

wyardley commented Mar 8, 2023

kajinamit commented Mar 8, 2023

wyardley commented Mar 8, 2023

kajinamit commented Mar 8, 2023

kajinamit commented Mar 8, 2023

wyardley commented Mar 8, 2023

bastelfreak commented Mar 8, 2023

kajinamit commented Mar 9, 2023

wyardley commented May 19, 2024

kajinamit Jul 3, 2022 •

edited

Loading

wyardley commented Mar 8, 2023 •

edited

Loading

kajinamit commented Mar 8, 2023 •

edited

Loading