modulesync 2.1.0 & add puppet 6 support #271
Conversation
|
I did a bit of testing using my test puppet master. I upgraded it to Puppet 6 and then added selinux_core to an environment containing puppet 5 agents. It seems the puppet 5 agents either ignore or do not mind that they get synced the extra providers; selmodule seems to continue working as previously. Therefore it seems safe to include the dependency on selinux_core in the metadata file, though I'm still undecided as to whether we should. |
|
https://puppet.com/docs/puppet/6.0/type.html#supported-types-in-modules states that selmodule is included in the puppet 6 distribution. Therefore having it as a dependency is redundant, since it is already implied by having Puppet installed. |
|
@oranenj What we're not 100% sure on is the implications of putting it in I'd still like to wait a bit longer for some guidance to come back from puppet. ping @binford2k ;) Maybe puppet will ship the core modules as gems?? Maybe they'll update puppetlabs_spec_helper?? |
bastelfreak
force-pushed
the
modulesync
branch
from
4bbbb32 to
7d79d8b
Compare
Gemfile
Outdated
| @@ -11,8 +11,7 @@ def location_for(place, fake_version = nil) | |||
| end | |||
|
|
|||
| group :test do | |||
| gem 'puppetlabs_spec_helper', '~> 2.6', :require => false | |||
| gem 'rspec-puppet', '~> 2.5', :require => false | |||
| gem 'puppetlabs_spec_helper', '>= 2.10.0', :require => false | |||
There was a problem hiding this comment.
2.11.0 has the change needed for .fixtures
modulesync 2.1.0 & add puppet 6 support
Pull Request (PR) description
This Pull Request (PR) fixes the following issues