Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change validate_array($global_tags) to validate_hash($global_tags) #10

Merged
merged 1 commit into from
Mar 30, 2016

Conversation

stuartbfox
Copy link
Contributor

Tests were failing with Failure/Error: raise Puppet::ParseError, ("#{arg.inspect} is not an Array. It looks to be a #{arg.class}")

@yankcrime
Copy link
Member

Thanks for this! Any chance you can update the relevant comment in init.pp where this is mistakenly called out as an array, and also maybe update the existing test to include some values for global_tags?

@stuartbfox
Copy link
Contributor Author

I have a much bigger PR inbound with more extensive tests, should be ready tomorrow

@yankcrime
Copy link
Member

Thanks @stuartbfox - I'll merge this for now then 👍

@yankcrime yankcrime merged commit da378df into voxpupuli:master Mar 30, 2016
stuartbfox pushed a commit to stuartbfox/puppet-telegraf that referenced this pull request Mar 31, 2016
Change validate_array($global_tags) to validate_hash($global_tags)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants