Some basic Vox Pupuli migration changes #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done automatically by modern versions of rspec-puppet.
`symlinks` section isn't needed. `puppetlabs-spec-helper` does this automatically. Test with latest github version of `stdlib`.
Cos. everyone loves badges!
It's deprecated and contained nothing useful. (Modern equivalent is `examples` directory).
|
More to follow in separate PRs. |
|
I'm not really concerned about those test failures yet. Not until we do the modulesync anyway. |
ekohl
approved these changes
Nov 25, 2018
There was a problem hiding this comment.
Submitted voxpupuli/modulesync_config#517 to make sure our modulesyncs take care of the coverage spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.