Fixing support for 5.5 agents on Debian #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! |
ekohl
reviewed
May 5, 2020
| apt::source { 'influxdata': | ||
| comment => 'Mirror for InfluxData packages', | ||
| location => "${telegraf::repo_location}${facts['os']['name'].downcase}", | ||
| release => $facts['os']['distro']['codename'], | ||
| release => $release, |
There was a problem hiding this comment.
Wasn't it better to just leave this parameter out? https://github.com/puppetlabs/puppetlabs-apt/blob/2df4e59aad25864f7d674f598d95628f68dfd4e1/manifests/source.pp#L75-L83 has code to deal with this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
I have some Debian 8 systems that are stuck on 5.5 due to the old ruby and there is no AIO agent for that platform. These were broken due to facts not resolving the same with facter 2.5.6. Also, the v 6 agent is unusable on some Debian 10 systems as they have very low memory, but 5.5 works ok.
This Pull Request (PR) fixes the following issues
Fixes compilation on Debian systems with puppet 5.5.17 and facter 2.5.6.