Add support for Darwin #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yachub
force-pushed
the
add_darwin_support
branch
4 times, most recently
from
93cbe45 to
de7cc51
Compare
yachub
force-pushed
the
add_darwin_support
branch
from
de7cc51 to
72f175b
Compare
ghoneycutt
approved these changes
Feb 12, 2021
genebean
requested changes
Feb 17, 2021
yachub
force-pushed
the
add_darwin_support
branch
from
72f175b to
74a0c25
Compare
genebean
approved these changes
Feb 17, 2021
yachub
force-pushed
the
add_darwin_support
branch
from
74a0c25 to
bc43f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Darwin 18 & 19 (macOS 10.14 and macOS 10.15). Only 18 is included in the metadata for testing because the next release of facterdb should include a new set of facts for Darwin 19.
Please let me know what you think and if you would like to see any changes or have suggestions.
I'm currently investigating how to add acceptance tests for macos using GitHub Actions.
Thanks!